Merge pull request #362 from romuloceccon/transliterate_non_ascii

Fix transliteration to default replacement char
ruby-i18n · Feb 22, 2017 · 96f6e70 · 96f6e70
2 parents 529d61c + 6b60a5b
commit 96f6e70
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/i18n/backend/transliterator.rb b/lib/i18n/backend/transliterator.rb
@@ -75,7 +75,8 @@ def initialize(rule = nil)
           add rule if rule
         end
 
-        def transliterate(string, replacement = DEFAULT_REPLACEMENT_CHAR)
+        def transliterate(string, replacement = nil)
+          replacement ||= DEFAULT_REPLACEMENT_CHAR
           string.gsub(/[^\x00-\x7f]/u) do |char|
             approximations[char] || replacement
           end

diff --git a/test/i18n_test.rb b/test/i18n_test.rb
@@ -351,6 +351,10 @@ def call(exception, locale, key, options); key; end
     end
   end
 
+  test "transliterate non-ASCII chars not in map with default replacement char" do
+    assert_equal "???", I18n.transliterate("日本語")
+  end
+
   test "I18n.locale_available? returns true when the passed locale is available" do
     I18n.available_locales = [:en, :de]
     assert_equal true, I18n.locale_available?(:de)