Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EOFError raised by Rack #2161

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Handle EOFError raised by Rack #2161

merged 5 commits into from
Feb 10, 2021

Commits on Feb 9, 2021

  1. Handle EOFError raised by Rack 

    In v2.2.0, Rack started raising an EOFError when given an empty body with a
multipart upload - rack/rack#1572  Previously, Rack had
swallowed this error.
    @bschmeck
    bschmeck committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f405ecb View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Don't hardcode the content type when encountering an EOFError 

    We most likely are here due to a multipart/form-data Content-Type, but there's
no guarantee of that.
    @bschmeck
    bschmeck committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    08bb693 View commit details
    Browse the repository at this point in the history

  2. Use Gem::Version instead of directly parsing Rack's version 

    Also move the conditional to a spec condition, to properly skip the spec on
versions of Rack that don't raise an error.
    @bschmeck
    bschmeck committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c1dd89a View commit details
    Browse the repository at this point in the history

  3. Use a custom EmptyMessageBody exception, instead of reusing InvalidMe… 

    …ssageBody
    @bschmeck
    bschmeck committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ca030b1 View commit details
    Browse the repository at this point in the history

  4. Add Rack 2.2 to the test matrix

    @bschmeck
    bschmeck committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    e9fb53e View commit details
    Browse the repository at this point in the history