-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Various fixes #1323
base: master
Are you sure you want to change the base?
[WIP] Various fixes #1323
Conversation
[ci skip]
While this is open, is it worth it to remove support for Ruby 1.9.3? It has already EOL'd, and isn't included in the Travis build matrix... |
|
||
gem 'rack', '1.5.2' | ||
gem "rack", "1.5.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this back to 1.8.x syntax?
Anything not in the Travis matrix is not supported, so yes. |
Add a comment here when the build passes, don't get notifications on additional commits. |
Bump @maclover7, want to finish this? Part of this? |
This main holding issue is my rack-contrib PR 😬 |
cc @dblock