Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop gem to version ~> 0.68.1 #41

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

fotos
Copy link
Contributor

@fotos fotos commented Jan 9, 2020

Fixes build by updating and locking rubocop gem to version ~> 0.68.1.

Version 0.68.1 is the last version that supports Ruby 2.2, since version 0.69.0 dropped Ruby 2.2 support in rubocop/rubocop#6945.

Additionally Layout/IndentHash has been renamed to IndentFirstHashElement in 0.68.0.

We should probably consider dropping support for Ruby 2.2, in a separate MR, since it has reached EOL since March 2018.

@grape-bot
Copy link

grape-bot commented Jan 9, 2020

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#41](https://github.com/ruby-grape/grape-swagger-entity/pull/41): Update rubocop gem to version ~> 0.68.1 - [@fotos](https://github.com/fotos).

Generated by 🚫 danger

@LeFnord
Copy link
Member

LeFnord commented Jan 9, 2020

thanks @fotos

yeap, support for ruby 2.2 will be droped in one of the next releases

@kzaitsev
Copy link
Collaborator

kzaitsev commented Jan 9, 2020

@fotos Hello, thanks for your contribution

@kzaitsev kzaitsev merged commit 88aa850 into ruby-grape:master Jan 9, 2020
@kzaitsev
Copy link
Collaborator

kzaitsev commented Jan 9, 2020

@LeFnord Hi Peter, do you have a plan to release grape-swagger 0.34.0?

After #40 I have a plan to release 0.3.4, as the last version which supports ruby 2.2.x and 2.3.x ( and add a new rubies to CI ).

I want to lock next releases on 0.4.x to grape-swagger 0.34.0 and greater.

@LeFnord
Copy link
Member

LeFnord commented Jan 9, 2020

Yeah the next release is comming, after this grape-swagger#738 is mörged, this will be the last one with supprt for grape < 1.3.0

after this is done, I will prepare the 1.0.0, which supports grape >= 1.3.0, have to do it so, cause of breaking changes (virtus vs. dry-types) and will be released after grape 1.3.0 was

@fotos fotos deleted the fix-rubocop branch January 9, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants