Show log(x).since combination in README #701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.
Description
.log.since
respects the default count configuration which makes sense but isn't clear in the examples or the docs.Perhaps naively I expected
g.log.since('1 month ago')
to return a whole month's worth of commits. Instead it consistently returned 30 which is the default for thecount
param. To return a whole month you have to also specify a greater maximum i.e.g.log(1000).since('1 month ago')
depending on the amount of activity in the repository.