Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show log(x).since combination in README #701

Merged
merged 1 commit into from Mar 19, 2024
Merged

Conversation

jcouball
Copy link
Member

Signed-off-by: James Couball jcouball@yahoo.com

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

  • Adds some more detail to the README for the log function, specifically around combining with other filters.

.log.since respects the default count configuration which makes sense but isn't clear in the examples or the docs.
Perhaps naively I expected g.log.since('1 month ago') to return a whole month's worth of commits. Instead it consistently returned 30 which is the default for the count param. To return a whole month you have to also specify a greater maximum i.e. g.log(1000).since('1 month ago') depending on the amount of activity in the repository.

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball
Copy link
Member Author

This is the change that was meant to go in #699 for the 2.x release line.

@jcouball jcouball merged commit e4d6a77 into master Mar 19, 2024
9 of 10 checks passed
@jcouball jcouball deleted the update_log_doc_2_x branch March 19, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant