Do not change global env #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead pass relevant environment to the actual shell command being run Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
do-not-change-global-env
branch
3 times, most recently
from
106d8e8
to
4a969a0
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
do-not-change-global-env
branch
2 times, most recently
from
d029e4c
to
3e12987
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
do-not-change-global-env
branch
from
3e12987
to
d684854
Compare
|
Some version of this would be nice to have: the current global env version in practice means only one git operation can run at a time per process, which is rather inconvenient. Unless I'm missing something, based on what was merged in #673 I think this can be changed to just have "option 2" (capture2/popen2) and is then probably in a good state? |
|
All methods I have tried did not work for one reason or another in JRuby on Windows. I have released git-2.0.0-pre1 which I believe will address this issue in a different way. You can see PR #684 for details. This version still does not support JRuby for Windows, but I believe there is a path to victory there. The API of this gem is unchanged. All the changes are below the hood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.
Description
Do not change ENV variables of a current process. Instead pass relevant environment to the actual shell command being run.
this PR is built on top of #673