Make Concurrent::Set
thread-safe on CRuby
#906
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #900 for original issue pointing out that
Concurrent::Set#each
(and other methods as well) are not thread-safe because the implementation was short-circuited to be::Set
.This PR adds two commits:
#each
combined with#add
and#delete
Set
implementation that usesMonitor
to synchronize across all instance methodsThis approach, using a new method
ThreadSafe::Util.make_synchronized_on_cruby
, borrows heavily from the approach used for Rubinius (seeThreadSafe::Util.make_synchronized_on_rbx
).Please let me know if this approach is too naïve, I fear I may be missing something obvious.