Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Array/Hash/Set construction broken on TruffleRuby #734

Merged
merged 9 commits into from Jul 5, 2018
Merged

Fix Array/Hash/Set construction broken on TruffleRuby #734

merged 9 commits into from Jul 5, 2018

Commits on Jun 24, 2018

  1. Move concurrency specs into groups

    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    2e1c6fa View commit details
    Browse the repository at this point in the history

  2. Add specs for Array initialization behavior

    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    aaa7da1 View commit details
    Browse the repository at this point in the history

  3. Add specs for Hash initialization behavior

    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    d62d9eb View commit details
    Browse the repository at this point in the history

  4. Add specs for Set initialization behavior

    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    9be3236 View commit details
    Browse the repository at this point in the history

  5. Fix broken initialization arguments on TruffleRuby 

    The `make_synchronized_on_rbx` method is used to intercept the `.new`
method on Array/Hash/Set but it broke whenever the `.new` was being used
with arguments.

(This was shown by the Array/Hash/Set specs that were added in the
previous commits being broken on TruffleRuby.)
    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    3fabacb View commit details
    Browse the repository at this point in the history

  6. Fix Array/Hash monitor not being initialized 

    Fixes several broken testcases in the Array and Hash specs.
    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    1788840 View commit details
    Browse the repository at this point in the history

  7. Fix another case of Hash monitor not being initialized

    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    e8ee0d2 View commit details
    Browse the repository at this point in the history

  8. Add developer-friendly error when monitor not initialized 

    As I'm fixing monitor initialization issues, it seems to me that the
current approach is a bit whack-a-mole so let's at least prepare a nice
error message for users to get in case we're still missing a few corner
cases.
    @ivoanjo
    ivoanjo committed Jun 24, 2018
    Copy the full SHA
    04db895 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. Revert previous changes for TruffleRuby 

    * use same approach as for JRuby
* use non public TruffleRuby API for simplicity
    @pitr-ch
    pitr-ch committed Jul 1, 2018
    Copy the full SHA
    bdcd61f View commit details
    Browse the repository at this point in the history