Move AtomicMarkableReference out of Edge #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,5 @@ | |||
| module Concurrent | |||
| module Edge | |||
|
|
|||
| module Atomic | |||
There was a problem hiding this comment.
There is no Atomic module. We are non-idiomatic in the way we handle some subdirectories and namespaces. We are going to fix this in 2.0. For now please leave atomic_markable_reference.rb in the lib/concurrent/atomic directory but make the namespace Concurrent:: AtomicMarkableReference.
|
After 1.0 is released we'll make a concerted effort to move more things from edge to core. For the 1.0 release (before the end of the month) this will need to stay in edge. We can keep this PR open for now but not merge it. |
pitr-ch
added
enhancement
|
replaced by #737 |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to get this in at some point .Originally, it was planned for 1.0 but that is fine if it is not possible. Let me know your thoughts.