Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 1.9.3 and JRuby 1.7 support #772

Closed
2 tasks
pitr-ch opened this issue Nov 5, 2018 · 7 comments
Closed
2 tasks

Drop Ruby 1.9.3 and JRuby 1.7 support #772

pitr-ch opened this issue Nov 5, 2018 · 7 comments
Assignees
Labels
enhancement Adding features, adding tests, improving documentation.

Comments

@pitr-ch
Copy link
Member

pitr-ch commented Nov 5, 2018

  • communicate with authors of depending gems
  • think out and describe here how it will be dropped
@pitr-ch pitr-ch added enhancement Adding features, adding tests, improving documentation. high-priority Should be done ASAP. labels Nov 5, 2018
@pitr-ch pitr-ch self-assigned this Nov 5, 2018
@nijikon
Copy link

nijikon commented Nov 5, 2018

Can we also drop 2.0, 2.1 and 2.2 support?

@jeremyevans
Copy link

Related to this, concurrent-ruby 1.1.1 is already broken on ruby 1.9.3 because it uses LoadError#path, which wasn't added until 2.0.0 (

).

This broke Sequel's tests on ruby 1.9.3: https://travis-ci.org/jeremyevans/sequel/jobs/451114760

You may want to consider pushing out 1.1.2 quickly, and either bumping required ruby version to 2.0.0 or reverting the LoadError#path usage or making it conditional.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 6, 2018

@jeremyevans thanks for letting me know. However I've fixed that problem, I run into it as well. Maybe just part of concurrent-ruby is required which then misses the utility/1.9.3 file. I'll release 1.1.2 which will be more defensive today, see #773. You can then remove the restriction

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 6, 2018

@jeremyevans 1.1.2 is pushed, please let me know if it works for you.

@jeremyevans
Copy link

@pitr-ch Yep, looks good here, thank you for the quick fix: https://travis-ci.org/jeremyevans/sequel/jobs/451424245

@pitr-ch pitr-ch added this to Nope in Hackathon Aug 24, 2019
@chrisseaton chrisseaton removed the high-priority Should be done ASAP. label Mar 8, 2022
@chrisseaton
Copy link
Member

Nobody serious is using 1.9 at the moment. We only support JRuby latest at the moment. We'll re-evaluate support Ruby versions in the future.

ruby-concurrency/concurrent-ruby automation moved this from Backlog to Done Mar 15, 2022
@jeremyevans
Copy link

@chrisseaton If you are going to close this, can you please update the gemspec: https://github.com/ruby-concurrency/concurrent-ruby/blob/master/concurrent-ruby.gemspec#L30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation.
Development

No branches or pull requests

4 participants