New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0 is a breaking build but wasn't marked as such #768
Comments
This is unfortunate, I was thinking 1.9.3 is so old that it won't be an issue for anybody (eol was 3.5 years ago). I've updated the release notes and changelog to include the change that 2.0 is required, (sorry it slipped) that I could do immediately. Could you limit concurrent-ruby version in your Gemfile to 1.0.5 to fix your CI immediately? The motivation behind dropping support of Ruby bellow 2.0 is to be able to start adding APIs with keywords. We cannot support 1.9.3 forever. So it's quite desirable to do. I'd like to know more and understand better the problems this is causing before doing anything. However currently I think the 1.9.3 support drop for 1.1 was ok. I think It does not make the gem backward incompatible, although users need to meet new requirement. When ruby is >= 2.0 everything should work as before, the gem is backward compatible. Users can also stay with 1.0.5 using version restriction in Gemfile until they are able to migrate. |
Hey @pitr-ch, thanks for the response! I've limited my version to 1.0.5 to fix this issue for the mean time. For many gems that maintain compatibility for 1.9.3, if they include a dependency on I can certainly understand that dropping 1.9.3 support is desirable. However, the point here is that |
Hm indeed |
Just FYI, because 1.1 was yanked we had a production deploy fail:
Easy fix, we can go back to 1.0.5, but 1.1.0 wasn't bothering us and yanking caused minor inconvenience. |
Same here. v1.1.0 was fine for us. |
Same issue here today - what a pain. :) |
Broke the openstreetmap production deployment as well - bundle was updated last night and then when we deployed it today the servers could no longer install the dependencies :-( |
Sorry guys, did not realize yank can be so disruptive. Lesson learned 👍 |
I don't see any reason why we should still support |
Any news on 1.1.1 being uploaded? My builds are still breaking. |
A quick solution will be to add |
You may wish to follow #772 - which will later describe how the 1.9.3 will be dropped. |
1.1.0 was released, but it requires ruby
>= 2.0.0
. Previously (in 1.0.5), it was marked as>= 1.9.3
.This change is breaking for many CI systems running tests for ruby 1.9. Should we release a new minor and mark this version as bad?
The text was updated successfully, but these errors were encountered: