Merge pull request #707 from ianks/safe-atomic-boolean-operations

Ensure memory barriers when setting/getting atomic boolean
ruby-concurrency · May 7, 2018 · b461ffc · b461ffc
2 parents 3c90f82 + b93f433
commit b461ffc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -25,4 +25,10 @@ tmtags
 .DS_Store
 .githubtoken
 
-spec/examples.txt
+# Rspec created files
+spec/examples.txt
+
+# Compiled files
+lib/concurrent_ruby_ext.jar
+lib/concurrent/extension.so
+lib/concurrent/extension.bundle
diff --git a/ext/concurrent/atomic_boolean.c b/ext/concurrent/atomic_boolean.c
@@ -21,13 +21,12 @@ VALUE method_atomic_boolean_initialize(int argc, VALUE* argv, VALUE self) {
 }
 
 VALUE method_atomic_boolean_value(VALUE self) {
-  return (VALUE) DATA_PTR(self);
+  return(ir_get(self));
 }
 
 VALUE method_atomic_boolean_value_set(VALUE self, VALUE value) {
   VALUE new_value = TRUTHY(value);
-  DATA_PTR(self) = (void *) new_value;
-  return(new_value);
+  return(ir_set(self, new_value));
 }
 
 VALUE method_atomic_boolean_true_question(VALUE self) {