Add a rationale for the "first and last" rule #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's just easier to read (e.g. not every language has the concept of negative indices), but I guess we failed to explain this. :-) I think it'd be better to add some rationale instead. |
ydakuka
force-pushed
the
remove-first-and-last-rule
branch
from
8faf782
to
52968ed
Compare
ydakuka
changed the title
|
Ok, I've done it. |
bbatsov
reviewed
Nov 22, 2023
| @@ -4240,6 +4240,7 @@ arr[100] = 1 # now you have an array with lots of nils | |||
| === `first` and `last` [[first-and-last]] | |||
|
|
|||
| When accessing the first or last element from an array, prefer `first` or `last` over `[0]` or `[-1]`. | |||
| `first` and `last` take less effort to understand, especially for a less experienced Ruby programmer or someone from a language with different indexing semantics. | |||
There was a problem hiding this comment.
Might be nice to add a couple of examples here as well.
ydakuka
force-pushed
the
remove-first-and-last-rule
branch
from
52968ed
to
32c2a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand the benefits of this rule when using ActiveRecord (for example), but I don't see any reason why I should do this when using pure Ruby.