Refine an example for "Suppressing Exceptions" rule #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rubocop/rubocop#7805 (comment). This PR refines an example for "Suppressing Exceptions" rule. And `do_something rescue nil` will be changed from bad case to good case based on RuboCop (0.81)'s behavior and the comment below. rubocop/rubocop#7297 (comment)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of rubocop/rubocop#7805 (comment).
This PR refines an example for "Suppressing Exceptions" rule.
And
do_something rescue nilwill be changed from bad case to good case based on RuboCop (0.81)'s behavior and the comment below.rubocop/rubocop#7297 (comment)