Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless block arg comma #789

Merged
merged 4 commits into from Jan 26, 2020
Merged

Conversation

ty-porter
Copy link
Contributor

In reference to rubocop/rubocop#7637.

Adds style guide for block arguments to omit any trailing commas except in single argument cases where functionality would be affected.

@bbatsov
Copy link
Collaborator

bbatsov commented Jan 15, 2020

You might some clarification that when you have a single param this is actually doing destructuring and that's the difference.

README.adoc Outdated Show resolved Hide resolved
@bbatsov bbatsov merged commit 92f9915 into rubocop:master Jan 26, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants