[Fix #9962] Update Style/WordArray to register an offense in percent style if any values contain spaces
#9981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
commented
Aug 4, 2021
lib/rubocop/cop/style/word_array.rb
Outdated
Comment on lines
76
to
79
| def invalid_percent_array_contents?(node) | ||
| # Disallow %w() arrays that contain invalid encoding or spaces | ||
| complex_content?(node.values, word_regex: false) | ||
| end |
There was a problem hiding this comment.
Originally this used the same complex_content? check, taking the WordRegex configuration into account, however, this caused 206 offenses on rubocop itself, disallowing a lot of %w() arrays that are probably good to keep (ie. they contained non word characters). For instance:
As a result, I made the check only look for space issues. If desired we could add in another configuration to specify a regex for this check?
… `percent` style if any values contain spaces.
dvandersluis
force-pushed
the
issue/9962
branch
from
dc95597
to
4f76885
Compare
|
Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Style/WordArrayto mark%w()arrays as offenses if they contain any values with spaces.Fixes #9962.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.