Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9977] Update Layout/EmptyLineAfterGuardClause to not register an offense if there is another expression following the guard clause on the same line #9978

Merged
merged 2 commits into from Aug 5, 2021

Conversation

dvandersluis
Copy link
Member

Layout/EmptyLineAfterGuardClause corrects by adding a blank line after the clause, assuming that it is on its own line (or followed by a comment). However, if there is another statement on the same line, it's not taken into account.

This change does not attempt to correct if the clause is not the last node on the line. It'll leave autocorrection to Style/Semicolon (which currently doesn't do this autocorrection either).

Fixes #9977.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis changed the title [Fix #9977] Skip autocorrection for Layout/EmptyLineAfterGuardClause if there is another node on the same line [Fix #9977] Update Layout/EmptyLineAfterGuardClause to not register an offense if there is another expression following the guard clause on the same line Aug 4, 2021
…egister an offense if there is another expression following the guard clause on the same line.
@mergify mergify bot merged commit 984fcea into rubocop:master Aug 5, 2021
@dvandersluis dvandersluis deleted the issue/9977 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/EmptyLineAfterGuardClause inserts empty line outside of block, breaking method chaining
2 participants