Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9955] Fix Style/ExplicitBlockArgument adding a second set of parentheses #9967

Merged
merged 1 commit into from Aug 3, 2021

Conversation

dvandersluis
Copy link
Member

When Style/ExplicitBlockArgument adds the block argument to a def or send node, if the node already had empty parentheses after it, the corrector would add a second set, ie:

def my_method()
  foo { yield }
end

would become

def my_method(&block)()
  foo(&block)
end

In the original issue, once all these corrections (plus from Lint/UnusedMethodArgument and Style/DefWithParentheses) were resolved, the method would end up without a block argument.

Fixes #9955.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis force-pushed the issue/9955 branch 2 times, most recently from 84d8613 to ef34c56 Compare July 30, 2021 21:02
@bbatsov bbatsov merged commit b4675b4 into rubocop:master Aug 3, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 3, 2021

Someone's on a hot PR streak! 😆 🚀

@dvandersluis dvandersluis deleted the issue/9955 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default configuration for UnusedMethodArgument+ExplicitBlockArgument breaking existing code
2 participants