[Fix #9957] Add WholeWord
configuration to Naming/InclusiveLanguage
's FlaggedTerms
config
#9965
+49
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive fix for #9957.
Allows
FlaggedTerms
to be set up to only match against a whole word (and enables it forslave
). This allows false positives likeSLAVersion
andTeslaVehicle
to not be flagged by the cop.However, we don't have an inflector for identifiers, and this cop is explicitly case insensitive, which means that enabling this will also stop flagging partial word matches like
DatabaseSlave
. This really only affects class names sincedatabase_slave
will still be flagged.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.