Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9954] Fix an infinite loop error for Layout/HashAlignment #9956

Conversation

koic
Copy link
Member

@koic koic commented Jul 29, 2021

Fixes #9954.

This PR fixes an infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#9954.

This PR fixes an infinite loop error for `Layout/HashAlignment` when
`EnforcedStyle: with_fixed_indentation` is specified for `Layout/ArgumentAlignment`.
@koic koic force-pushed the fix_an_infinite_loop_error_for_layout_hash_alignment branch from 210da64 to 563bfd2 Compare July 29, 2021 02:03
@bbatsov bbatsov merged commit 06d0eba into rubocop:master Aug 3, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 3, 2021

Looks good!

@koic koic deleted the fix_an_infinite_loop_error_for_layout_hash_alignment branch August 3, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop using Layout/ArgumentAlignment (with: with_fixed_indentation)
2 participants