[Fix #9940] Fix an incorrect auto-correct for Style/HashTransformValues
#9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 19, 2021
changelog/fix_incorrect_autocorrect_for_style_hash_transform_values.md
Outdated
Show resolved
Hide resolved
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_hash_transform_values
branch
2 times, most recently
from
7e567ac
to
27ac9b1
Compare
koic
changed the title
Style/Style/HashTransformValuesStyle/HashTransformValues
…formValues` Fixes rubocop#9940. This PR fixes an incorrect auto-correct for `Style/HashTransformValues` when value is a hash literal for `_.to_h{...}`.
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_hash_transform_values
branch
from
27ac9b1
to
867c9b2
Compare
|
Thanks! |
koic
deleted the
fix_incorrect_autocorrect_for_style_hash_transform_values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9940.
This PR fixes an incorrect auto-correct for
Style/HashTransformValueswhen value is a hash literal for_.to_h{...}.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.