Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Layout/LineLength #9938

Merged

Commits on Jul 17, 2021

  1. Fix an incorrect auto-correct for Layout/LineLength

    This PR fixes the following incorrect auto-correct for `Layout/LineLength`
    when a heredoc is used as the first element of an array.
    
    ```console
    % cat example.rb
    [<<~STRING, { key1: value1, key2: value2 }]
    STRING
    
    % ruby -c example.rb
    Syntax OK
    
    % cat .rubocop.yml
    Layout/LineLength:
      Max: 40
    
    % bundle exec rubocop --only Layout/LineLength example.rb -a
    (snip)
    
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:1:41: C: [Corrected] Layout/LineLength: Line is too long. [43/40]
    [<<~STRING, { key1: value1, key2: value2 }]
                                            ^^^
    
    1 file inspected, 1 offense detected, 1 offense corrected
    
    % cat example.rb
    [<<~STRING,
    { key1: value1, key2: value2 }]
    STRING
    
    % ruby -c example.rb
    example.rb:1: syntax error, unexpected end-of-input, expecting ']'
    ```
    koic committed Jul 17, 2021
    Copy the full SHA
    e1edb41 View commit details
    Browse the repository at this point in the history