Fixup GitHub Actions formatter when run in non-default directory #9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojab
force-pushed
the
fixup_github_actions_formatter
branch
from
b464fa4
to
9a8ce73
Compare
|
And CircleCI forces me to login and give RW access to all repos (or only private repos, if I click on non-default login option) |
ojab
force-pushed
the
fixup_github_actions_formatter
branch
from
9a8ce73
to
0be1fec
Compare
|
GHA failures seems unrelated, hopefully CircleCI are the same, sending to review. |
koic
reviewed
Jul 16, 2021
ojab
force-pushed
the
fixup_github_actions_formatter
branch
3 times, most recently
from
a167d92
to
5ea2e17
Compare
In some cases (specifically when running inside the container with non-default `working-directory`) GitHub cannot link absolute paths produced by formatter to the code, while relative paths works. Output relative paths if they're inside current directory, so this usecase is covered.
ojab
force-pushed
the
fixup_github_actions_formatter
branch
from
5ea2e17
to
903a4f9
Compare
|
Ok, CI is green, but I swear that failures looked unrelated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (specifically when running inside the container with
non-default
working-directory) GitHub cannot link absolute pathsproduced by formatter to the code, while relative [to the project root]
paths works.
Output relative paths if they're inside current directory, so this
usecase is covered.
I can craft a public repo with reproducer, since I see this issue in private repo, but hopefully you believe me ._.
I doubt that we should care about usecases outside of GHA, so this PR could break reporting only if project is checked out into non-default directory and
rubocopruns from some outer directory (i. e. not from the project root), but such cases should be trivially fixable by changingworking-directory.In the case in question it's unfixable or non-trivially fixable because GHA message<->code matching rules are non-public.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.