Support Ruby 2.7's pattern matching for Lint/DuplicateBranch
#9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_pattern_matching_doc_and_test_for_lint_duplicate_branch
branch
2 times, most recently
from
5266372
to
ae0e458
Compare
This PR supports Ruby 2.7's pattern matching for `Lint/DuplicateBranch`. And this PR uses rubocop/rubocop-ast#192 feature, so it requires RuboCop AST 1.8.0 or higher.
koic
force-pushed
the
add_pattern_matching_doc_and_test_for_lint_duplicate_branch
branch
from
ae0e458
to
311cd0d
Compare
|
Nice! Thanks for tackling this! |
koic
deleted the
add_pattern_matching_doc_and_test_for_lint_duplicate_branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports Ruby 2.7's pattern matching for
Lint/DuplicateBranch.When rubocop/rubocop-ast#192 is merged, please remove theLint::DuplicateBranch#case_match_branches(node)private method and useAST::CaseMatchNode#branchesinstead.And this PR uses rubocop/rubocop-ast#192 feature, so it requires RuboCop AST 1.8.0 or higher.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.