Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix rubocop#9328] Honour shareable_constant_value magic comment #9929

Merged
merged 3 commits into from Aug 23, 2021
Merged

[Fix rubocop#9328] Honour shareable_constant_value magic comment #9929

merged 3 commits into from Aug 23, 2021

Commits on Aug 21, 2021

  1. [Fix rubocop#9328] Honour shareable_constant_value magic comment 

    [Fix rubocop#9328] Resolve review comments

[Fix rubocop#9328] Removing nil check, refactoring spec

[Fix rubocop#9328] Tests for code next to inline comments

[Fix rubocop#9328] Move module to mutable_constant
    @thearjunmdas
    thearjunmdas committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    4a13649 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. [Fix rubocop#9328] Add co-author, simple documentation

    @thearjunmdas
    thearjunmdas committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    a89c08b View commit details
    Browse the repository at this point in the history

  2. [Fix rubocop#9328] Added some examples to the cop

    @thearjunmdas
    thearjunmdas committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    e5258d4 View commit details
    Browse the repository at this point in the history