Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Layout/HashAlignment #9849

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 3, 2021

Resolves standardrb/standard#300

This PR fixes a false negative for Layout/HashAlignment when setting EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and using misaligned keyword arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Resolves standardrb/standard#300

This PR fixes a false negative for `Layout/HashAlignment` when
setting `EnforcedStyle: with_fixed_indentation` of `Layout/ArgumentAlignment`
and using misaligned keyword arguments.
@koic koic force-pushed the fix_a_false_negative_for_layout_hash_alignment branch from 0803906 to 2cc2f98 Compare June 3, 2021 16:49
@koic koic merged commit 2d4d6df into rubocop:master Jun 3, 2021
@koic koic deleted the fix_a_false_negative_for_layout_hash_alignment branch June 3, 2021 17:41
@agrobbin
Copy link

agrobbin commented Jun 9, 2021

@dvandersluis @koic I believe this has caused a subtle regression:

undefined method `loc' for nil:NilClass
/usr/local/var/rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/rubocop-1.16.1/lib/rubocop/cop/layout/hash_alignment.rb:221:in `autocorrect_incompatible_with_other_cops?'
/usr/local/var/rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/rubocop-1.16.1/lib/rubocop/cop/layout/hash_alignment.rb:206:in `on_hash'

We started getting this when Dependabot tried to bump us up to 1.16.1. The code it failed on isn't clear/consistent, but here are a couple of examples that triggered this exception that hopefully help!

{}.tap do |data|
Tags::TextField.new(form.object_name, attribute, form, {}).send(:tag_name, multiple?)

@dvandersluis
Copy link
Member

@agrobbin I think this is the same as #9861, I'll take a look.

@dvandersluis
Copy link
Member

Should be fixed by #9862.

@agrobbin
Copy link

agrobbin commented Jun 9, 2021

Perfect, thanks @dvandersluis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants