[Fix #9836] Fix incorrect corrections for Layout/HashAlignment
when a kwsplat
node is on the same line as a pair
node with table style
#9837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword splats were previously treated as pairs using colon style, which some hacks in the Alignment classes to handle them (see #3919). However, this did not account for all possibilities and would cause previous pairs on the same line as the
kwsplat
to be removed by autocorrection.Instead, now a special
KeywordSplatAlignment
type was added to handlekwsplat
s. The previously behaviour aboutkwsplat
s was retained (they will still be aligned with the beginning of the rest of the hash, regardless of enforced style), and the hacks inKeyAlignment
andTableAlignment
forkwsplat
s were removed.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.