Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #9793] Add Style/QuotedSymbols to enforce consistency in quoted symbols #9809

Merged
merged 2 commits into from May 19, 2021
Merged

[Fix #9793] Add Style/QuotedSymbols to enforce consistency in quoted symbols #9809

merged 2 commits into from May 19, 2021

Commits on May 17, 2021

  1. [Fix rubocop#9793] Add Style/QuotedSymbols to enforce consistency i… 

    …n quoted symbols.

Like `Style/StringLiterals`, this cop checks for the quoting style for symbols to be consistent. Checking whether a symbol _should_ be quoted or not is still handled by `Lint/SymbolConversion`.

This cop shares as much as possible with `Style/StringLiterals` for ease of maintainabilty. As well, for simple configuration, the default "style" is `same_as_string_literals` which will automatically apply the same configuration set up for `Style/StringLiterals` to this cop as well (it defaults to `single_quotes` if `StringLiterals` is not enabled).
    @dvandersluis
    dvandersluis committed May 17, 2021
    Copy the full SHA
    2fabcd8 View commit details
    Browse the repository at this point in the history

  2. Change Lint/SymbolConversion to only quote with double quotes, sinc… 

    …e `Style/QuotedSymbols` can now correct those to the correct quotes as per configuration.
    @dvandersluis
    dvandersluis committed May 17, 2021
    Copy the full SHA
    3ef1e32 View commit details
    Browse the repository at this point in the history