Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9799] Fix invalid line splitting by Layout/LineLength for send nodes with heredoc arguments #9800

Merged
merged 1 commit into from May 16, 2021

Conversation

dvandersluis
Copy link
Member

When a send node has heredoc arguments, the line cannot be split after the heredoc or it will be a syntax error.

Fixes #9799.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…for `send` nodes with heredoc arguments.
@koic koic merged commit fcde5d7 into rubocop:master May 16, 2021
@koic
Copy link
Member

koic commented May 16, 2021

Thanks!

@dvandersluis dvandersluis deleted the issue/9799 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/LineLength splits improperly when a send node has a heredoc argument
2 participants