Make Layout/ArgumentAlignment aware of kwargs
#9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `Layout/ArgumentAlignment` aware of kwargs and fixes standardrb/standard#216.
|
Thanks! |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 17, 2021
This PR fixes a false negative for `Layout/HashAlignment` when set `EnforcedStyle: with_fixed_indentation` of `ArgumentAlignment`. It is a regression of rubocop#9798.
bbatsov
pushed a commit
that referenced
this pull request
May 18, 2021
This PR fixes a false negative for `Layout/HashAlignment` when set `EnforcedStyle: with_fixed_indentation` of `ArgumentAlignment`. It is a regression of #9798.
|
This changes breaks when the only argument is a Hash. generate(
{
foo: "foo"
}
) |
|
@rafaelfranca This issue has been resolved by #9805 and #9812 and will be applied in the next release (Maybe RuboCop 1.16) . If my understanding of the issue seems different, please let me know. |
|
Yes, those PRs fix the issue. I'll wait the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Layout/ArgumentAlignmentaware of kwargs and fixes standardrb/standard#216.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.