Refactor redundant cop disable directive #9779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
force-pushed
the
fix/redundant_cop_disable_directive
branch
2 times, most recently
from
8507226
to
4b1c190
Compare
AndreiEres
force-pushed
the
fix/redundant_cop_disable_directive
branch
from
4b1c190
to
2f1ad5f
Compare
AndreiEres
force-pushed
the
fix/redundant_cop_disable_directive
branch
4 times, most recently
from
0e5b3b7
to
4f27af6
Compare
AndreiEres
force-pushed
the
fix/redundant_cop_disable_directive
branch
from
9c3b924
to
8c98109
Compare
AndreiEres
changed the title
|
@bbatsov @dvandersluis Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor redundant cop disable directive to prepare code for further working on redundant department disabling #9519
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.