[Fix #9773] Fix Style/EmptyLiteral
to not register offenses for String.new
when Style/FrozenStringLiteral
is enabled
#9774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/EmptyLiteral
replacesString.new
with''
, unless the file has afrozen-string-literal: true
magic comment. However, ifStyle/FrozenStringLiteral
is also enabled, this will cause broken code, because the magic comment will be added afterwards.This change makes string behaviour the same if
Style/FrozenStringLiteral
is enabled as if the magic comment is found. However, ifStyle/FrozenStringLiteral
is enabled but there is afrozen-string-literal: false
magic comment,Style/EmptyLiteral
will continue to replace the literal.Fixes #9773.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.