[Fix #9771] Fix a false positive for Style/TrivialAccessors
#9772
Conversation
|
I have the vague memory that this was by design, so people would uncover "accidental" accessors, regardless of the name. I also thought we had some configuration about the exactness of the name match, but I don't see it. I wonder if I'm thinking of some similar cop. :-) |
|
Ah, actually it seems we didn't include examples of the config options in the docs, which is why I didn't see them at first. I was thinking of |
Fixes rubocop#9771. This PR changes `AllowDSLWriters` to true by default because it's still a trivial accessor and most people are unlikely to be creating DSLs. By this will prevent a false positive for `Style/TrivialAccessors` when defining a method that is not a DSL writer.
koic
force-pushed
the
fix_false_positive_for_style_trivial_accessors
branch
from
5b0edda
to
d236803
Compare
|
Actually the issue was because the default value of I've updated PR by changing the default value from false to true for |
|
Great work with the examples! I had forgotten how many options this cop had, but now they will be a lot easier to comprehend/discover. |
Fixes #9771.
This PR fixes a false positive for
Style/TrivialAccessorswhen defining a method that is not a writer.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.