Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9761] Fix Style/ClassAndModuleChildren false negative for compact style when a class/module is partially nested #9765

Merged
merged 1 commit into from May 4, 2021

Conversation

dvandersluis
Copy link
Member

This fix makes Style/ClassAndModuleChildren register an offense for the following type of code with the compact style:

class Foo::Bar
  class Baz
  end
end

Fixes #9761.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…for `compact` style when a class/module is partially nested.
@bbatsov
Copy link
Collaborator

bbatsov commented May 4, 2021

Nice!

@dvandersluis dvandersluis deleted the issue/9761 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassAndModuleChildren compact syntax false negative when outer module is already nested
2 participants