[Fix #9750] Fix an incorrect auto-correct for Style/SoleNestedConditional
#9754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dConditional` Fixes rubocop#9750. This PR fixes an incorrect auto-correct for `Style/SoleNestedConditional` when when using nested `if` within `unless foo == bar`. This patch leaves auto-correction from `(!foo == bar)` to `foo != bar` to `Style/InverseMethods` cop thus simplify its role and implementation. And this PR adds a cli test to prevent unintended auto-correction when using `Style/IfUnlessModifier` together for the patch.
koic
force-pushed
the
fix_an_incorrect_autocorrect_for_style_sole_nested_conditional_cop
branch
from
921cfc8
to
426e30f
Compare
koic
deleted the
fix_an_incorrect_autocorrect_for_style_sole_nested_conditional_cop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9750.
This PR fixes an incorrect auto-correct for
Style/SoleNestedConditionalwhen when using nestedifwithinunless foo == bar.This patch leaves auto-correction from
(!foo == bar)tofoo != bartoStyle/InverseMethodscop thus simplify its role and implementation. And this PR adds a cli test to prevent unintended auto-correction when usingStyle/IfUnlessModifiertogether for the patch.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.