[Fix #9713] Skip autocorrection for block_local_variables in Lint/UnusedBlockArgument
#9714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
210
to
207
| 1.times do |index; x| | ||
| ^ #{message} | ||
| x = 10 | ||
| puts index | ||
| end |
There was a problem hiding this comment.
Why is this an offense? The block variable is used?
|
I agree with @dvandersluis's concern. The issue is a false positive when using a local variable defined outside the block as a block variable. It requires testing based on #9713 and fix to the false positive. Unfortunately, skipping auto-correction does not solve the issue 😢 |
|
@koic @dvandersluis This was an existing behaviour which I assumed was intentional because the variable assigned inside block is not really used. |
tejasbubane
force-pushed
the
fix-9713
branch
3 times, most recently
from
97e9080
to
aec8232
Compare
|
I have changed code to not register offense in this case. |
…int/UnusedBlockArgument` Closes rubocop#9713
koic
approved these changes
Apr 20, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there is a better solution. But I think this cop should restrict itself to arguments and not make corrections within block body as suggested in the issue.
Closes #9713
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.