Fix an incorrect auto-correct for Style/HashConversion

changelog/fix_an_incorrect_autocorrect_for_style_hash_conversion.md

@@ -0,0 +1 @@
+* [#9712](https://github.com/rubocop/rubocop/pull/9712): Fix an incorrect auto-correct for `Style/HashConversion` when `Hash[]` as a method argument without parentheses. ([@koic][])

lib/rubocop/cop/style/hash_conversion.rb

@@ -84,6 +84,9 @@ def use_zip_method_without_argument?(first_argument)
         def register_offense_for_hash(node, hash_argument)
           add_offense(node, message: MSG_LITERAL_HASH_ARG) do |corrector|
             corrector.replace(node, "{#{hash_argument.source}}")
+
+            parent = node.parent
+            add_parentheses(parent, corrector) if parent&.send_type? && !parent.parenthesized?
           end
         end
 

spec/rubocop/cop/style/hash_conversion_spec.rb

@@ -34,6 +34,28 @@
     RUBY
   end
 
+  it 'reports different offense for hash argument Hash[] as a method argument with parentheses' do
+    expect_offense(<<~RUBY)
+      do_something(Hash[a: b, c: d], 42)
+                   ^^^^^^^^^^^^^^^^ Prefer literal hash to Hash[key: value, ...].
+    RUBY
+
+    expect_correction(<<~RUBY)
+      do_something({a: b, c: d}, 42)
+    RUBY
+  end
+
+  it 'reports different offense for hash argument Hash[] as a method argument without parentheses' do
+    expect_offense(<<~RUBY)
+      do_something Hash[a: b, c: d], 42
+                   ^^^^^^^^^^^^^^^^ Prefer literal hash to Hash[key: value, ...].
+    RUBY
+
+    expect_correction(<<~RUBY)
+      do_something({a: b, c: d}, 42)
+    RUBY
+  end
+
   it 'reports different offense for empty Hash[]' do
     expect_offense(<<~RUBY)
       Hash[]