Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Style/AndOr #9646

Merged

Commits on Mar 30, 2021

  1. Fix an incorrect auto-correct for Style/AndOr

    This PR fixes the following incorrect auto-correct for `EnforcedStyle: require_parentheses` of
    `Style/MethodCallWithArgsParentheses` with `EnforcedStyle: conditionals` of `Style/AndOr`.
    
    ```console
    % cat example.rb
    if foo and bar :arg
    end
    
    % rubocop --only Style/AndOr,Style/MethodCallWithArgsParentheses -a
    (snip)
    
    Offenses:
    
    example.rb:1:8: C: [Corrected] Style/AndOr: Use && instead of and.
    if foo and bar :arg
           ^^^
    example.rb:1:12: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
    parentheses for method calls with arguments.
    if foo and bar :arg
               ^^^^^^^^
    
    1 file inspected, 2 offenses detected, 2 offenses corrected
    ```
    
    ## Before
    
    ```console
    % cat example.rb
    if foo && bar(:arg))
    end
    
    % ruby -c example.rb
    example.rb:1: syntax error, unexpected ')', expecting `then' or ';' or '\n'
    if foo && bar(:arg))
    ```
    
    ## After
    
    ```console
    % cat example.rb
    if foo && bar(:arg)
    end
    ```
    koic committed Mar 30, 2021
    Copy the full SHA
    c6a6e7b View commit details
    Browse the repository at this point in the history