Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/MultilineMethodSignature #9644

Merged

Commits on Mar 26, 2021

  1. Fix an error for Style/MultilineMethodSignature

    This PR fixes the following error and the incorrect auto-correct for
    `Style/MultilineMethodSignature` when line break after opening parenthesis.
    
    ```ruby
    % cat example.rb
    class Foo
      def foo(
        arg
    )
      end
    end
    ```
    
    ## Before
    
    ```console
    % rubocop -a --only Style/MultilineMethodSignature example.rb
    (snip)
    
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:2:3: C: [Corrected] Style/MultilineMethodSignature: Avoid
    multi-line method signatures.
    def foo( ...
    ^^^^^^^^
    
    0 files inspected, 1 offense detected, 1 offense corrected
    Infinite loop detected in /private/tmp/example.rb and caused by Style/MultilineMethodSignature
    /Users/koic/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rubocop-1.12.0/lib/rubocop/runner.rb:304:in
    `check_for_infinite_loop'
    /Users/koic/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rubocop-1.12.0/lib/rubocop/runner.rb:287:in
    `block in iterate_until_no_changes'
    /Users/koic/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rubocop-1.12.0/lib/rubocop/runner.rb:286:in
    `loop'
    (snip)
    
    % cat example.rb
    class Foo
      def foo(
        arg)
      end
    end
    ```
    
    ## After
    
    ```console
    % rubocop -a --only Style/MultilineMethodSignature example.rb
    (snip)
    
    class Foo
      def foo(arg)
      end
    end
    ```
    koic committed Mar 26, 2021
    Copy the full SHA
    ec1b2ea View commit details
    Browse the repository at this point in the history