[Fix #9641] Fix Layout/MultilineMethodCallIndentation
triggering on method calls that look like operators
#9642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultilineExpressionIndentation#right_hand_side
, which is used by bothLayout/MultilineMethodCallIndentation
andLayout/MultilineOperationIndentation
was not correctly calculating the RHS when the send node looks like an operator but has a receiver (ie.foo.&
). This was leading to an autocorrection loop withLayout/ArgumentAlignment
,Layout/ClosingParenthesisIndentation
andLayout/FirstArgumentIndentation
.I split out the
right_hand_side
method to be defined in each of the two cops so that the right behaviour can be in place for each cop.Fixes #9641.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.