Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/RedundantBegin removing comments on assignment statement correction #9639

Merged
merged 1 commit into from Mar 29, 2021

Commits on Mar 25, 2021

  1. Fix Style/RedundantBegin removing comments on assignment statement …

    …correction
    
    `Style/RedundantBegin` cop currently removes comments that occur
    before the first child node of the `begin` block. This happens
    because comments are skipped when navigating the node tree.
    
    Currently,
    ```ruby
    var ||= begin
      # comment
      foo
    end
    ```
    will correct to
    ```ruby
    var ||= foo
    ```
    
    This PR changes that correction to
    ```ruby
    var ||= foo
    ```
    
    Other comments in the vicinity (before and after `begin/end` block,
    and after first child node) are still preserved, as they
    already were before this change.
    marcotc committed Mar 25, 2021
    Copy the full SHA
    7288acd View commit details
    Browse the repository at this point in the history