Parenthesized forwarded args in Style/MethodCallWithArgsParentheses omit_parentheses

changelog/fix_parentheses_in_forwarded_args_for_style_method_call_with_args_parentheses.md

@@ -0,0 +1 @@
+* [#9637](https://github.com/rubocop/rubocop/issues/9637): Allow parentheses for forwarded args in `Style/MethodCallWithArgsParentheses`'s `omit_parentheses` style to avoid endless range ambiguity. ([@gsamokovarov][])

lib/rubocop/cop/style/method_call_with_args_parentheses.rb

@@ -40,8 +40,12 @@ module Style
       #     to `true` allows the presence of parentheses in such a method call
       #     even with arguments.
       #
-      # NOTE: Parens are required around a method with arguments when inside an
-      # endless method definition (>= Ruby 3.0).
+      # NOTE: Parentheses are still allowed in cases where omitting them
+      # results in ambiguous or syntactically incorrect code. For example,
+      # parentheses are required around a method with arguments when inside an
+      # endless method definition introduced in Ruby 3.0.  Parentheses are also
+      # allowed when forwarding arguments with the triple-dot syntax introduced
+      # in Ruby 2.7 as omitting them starts an endless range.
       #
       # @example EnforcedStyle: require_parentheses (default)
       #

lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb

@@ -5,15 +5,14 @@ module Cop
     module Style
       class MethodCallWithArgsParentheses
         # Style omit_parentheses
-        # rubocop:disable Metrics/ModuleLength
+        # rubocop:disable Metrics/ModuleLength, Metrics/CyclomaticComplexity
         module OmitParentheses
           TRAILING_WHITESPACE_REGEX = /\s+\Z/.freeze
           OMIT_MSG = 'Omit parentheses for method calls with arguments.'
           private_constant :OMIT_MSG
 
           private
 
-          # rubocop:disable Metrics/CyclomaticComplexity
           def omit_parentheses(node)
             return unless node.parenthesized?
             return if inside_endless_method_def?(node)
@@ -27,7 +26,6 @@ def omit_parentheses(node)
               auto_correct(corrector, node)
             end
           end
-          # rubocop:enable Metrics/CyclomaticComplexity
 
           def auto_correct(corrector, node)
             if parentheses_at_the_end_of_multiline_call?(node)
@@ -114,7 +112,7 @@ def call_with_ambiguous_arguments?(node)
               call_as_argument_or_chain?(node) ||
               hash_literal_in_arguments?(node) ||
               node.descendants.any? do |n|
-                ambigious_literal?(n) || logical_operator?(n) ||
+                n.forwarded_args_type? || ambigious_literal?(n) || logical_operator?(n) ||
                   call_with_braced_block?(n)
               end
           end
@@ -190,7 +188,7 @@ def inside_string_interpolation?(node)
             node.ancestors.drop_while { |a| !a.begin_type? }.any?(&:dstr_type?)
           end
         end
-        # rubocop:enable Metrics/ModuleLength
+        # rubocop:enable Metrics/ModuleLength, Metrics/CyclomaticComplexity
       end
     end
   end

spec/rubocop/cop/style/method_call_with_args_parentheses_spec.rb

@@ -361,6 +361,26 @@ module Foo
 
     it_behaves_like 'endless methods', omit: true
 
+    context 'forwarded arguments in 2.7', :ruby27 do
+      it 'accepts parens for forwarded arguments' do
+        expect_no_offenses(<<~RUBY)
+          def delegated_call(...)
+            @proxy.call(...)
+          end
+        RUBY
+      end
+    end
+
+    context 'forwarded arguments in 3.0', :ruby30 do
+      it 'accepts parens for forwarded arguments' do
+        expect_no_offenses(<<~RUBY)
+          def method_missing(name, ...)
+            @proxy.call(name, ...)
+          end
+        RUBY
+      end
+    end
+
     it 'register an offense for parens in method call without args' do
       trailing_whitespace = ' '