[Fix #9622] Fixed Style/BisectedAttrAccessor
autocorrection to handle multiple bisected attrs in the same macro
#9634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being a pretty heavy refactor of the
Style/BisectedAttrAccessor
cop.Previously we were doing multiple passes at determining what macros are relevant for the cop, and which names within them. Despite that, if a macro had multiple names and was rewritten, we'd lose context of what other names there were and only the first one would survive the autocorrection.
Instead, I have now extracted a
Macro
value object that encapsulates all the data for the macro, including visibility (since macros of different visibilities are not combined), bisected and non-bisected attribute names, etc. When investigating a class, any macros found have objects created, and they are retained to be used to correct the class as a whole after wards (but we still register offenses on individual macro attributes as before).I have also added some more edge case tests that I encountered as I was working on this.
Fixes #9622.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.