Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9627] Fix an incorrect auto-correct for Style/StructInheritance #9628

Conversation

koic
Copy link
Member

@koic koic commented Mar 22, 2021

Fixes #9627.

This PR fixes an incorrect auto-correct for Style/StructInheritance when extending instance of Struct without do ... end and class body is empty.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…eritance`

Fixes rubocop#9627.

This PR fixes an incorrect auto-correct for `Style/StructInheritance` when
extending instance of Struct without `do` ... `end` and class body is empty.
@bbatsov bbatsov merged commit 0427ee4 into rubocop:master Mar 22, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 22, 2021

Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_style_struct_inheritance branch March 22, 2021 06:43
@snood1205
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/StructInheritance auto-correct can result in an empty block lint violation if the class is empty.
3 participants