Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop between Layout/IndentationWidth and Layout/RescueEnsureAlignment autocorrection #9619

Merged
merged 1 commit into from Mar 19, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Mar 19, 2021

There was an autocorrect infinite loop between Layout/IndentationWidth and Layout/RescueEnsureAlignment, as well as a false positive, for actually correct cases such as

def a
rescue StandardError
ensure
  a
end

due to Layout/IndentationWidth getting confused by there being no body before the rescue. It will now only check indentation of a rescue node if it has a body.

I also added a test to make sure the two cops autocorrect properly when used in unison.

Fixes standardrb/standard#112.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 11d647d into rubocop:master Mar 19, 2021
@koic
Copy link
Member

koic commented Mar 19, 2021

Thanks!

@dvandersluis dvandersluis deleted the fix/indentation-width-rescue branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/IndentationWidth is broken
2 participants