Fix infinite loop between Layout/IndentationWidth
and Layout/RescueEnsureAlignment
autocorrection
#9619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an autocorrect infinite loop between
Layout/IndentationWidth
andLayout/RescueEnsureAlignment
, as well as a false positive, for actually correct cases such asdue to
Layout/IndentationWidth
getting confused by there being no body before the rescue. It will now only check indentation of a rescue node if it has a body.I also added a test to make sure the two cops autocorrect properly when used in unison.
Fixes standardrb/standard#112.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.