Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9613] Fix a false positive for Style/RedundantSelf #9614

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 18, 2021

Fixes #9613.

This PR fixes a false positive for Style/RedundantSelf when a self receiver on an lvalue of mlhs arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#9613.

This PR fixes a false positive for `Style/RedundantSelf`
when a self receiver on an lvalue of mlhs arguments.
@bbatsov bbatsov merged commit f4fe4c9 into rubocop:master Mar 19, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 19, 2021

Looks good!

@koic koic deleted the fix_false_positive_for_style_redundant_self_cop branch March 19, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop Style/RedundantSelf changes the semantics of breakouted method arguments when autocorrecting
2 participants