Allow parentheses in safe navigation calls for Style/MethodCallWithArgsParentheses
#9612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgsParentheses` While calls like `foo&.[] bar` do compile, I won't blame people if they want to leave the parentheses so they know what's going on. I'm proposing we legitimize the parens in `foo&.[](bar)` and any other safe navigation calls. I don't think this deserves extra configuration either.
gsamokovarov
force-pushed
the
omit-parentheses-in-yield
branch
from
344f644
to
f6cbc01
Compare
|
It seems to me this has little to do with safe navigation and more to do with operator method names, as doing |
|
This makes sense, will open another PR with a change that allows parens for operator methods. |
|
👉 #9620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calls like
foo&.[] bardo compile, I won't blame people if theywant to leave the parentheses so they know what's going on, even if
they chose to use
EnforcedStyle: omit_parentheses.I'm proposing we legitimize the parens in
foo&.[](bar)and any othersafe navigation calls. I don't think this deserves extra configuration
either.
What do you folks think?