[Fix #9558] Fix inconsistency when dealing with URIs that are wrapped in single quotes vs double quotes

[dvandersluis]

The LineLength cop uses LineLengthHelp#allowed_uri_position? to determine if the URI is in an allowed position. Previously it checked that the URL either ended the line, or ended one character before the end of the line:

rubocop/lib/rubocop/cop/mixin/line_length_help.rb

Lines 26 to 30 in 291aec7

	def allowed_uri_position?(line, uri_range)
	uri_range.begin < max_line_length &&
	(uri_range.end == line_length(line) ||
	uri_range.end == line_length(line) - 1)
	end

It looks like this was added originally in #5361... also to handle disparity between single and double quotes. 🤔

As it turns out, ruby's default URI parser (which we use to match parts of strings as a URL), accepts ' as a valid character, but does not accept ". It also matches ). Therefore, the URL extracted from the string differs depending on the type of quote being used:

regexp = URI::DEFAULT_PARSER.make_regexp(['http', 'https'])
regexp.match(%q[http://foo.com/')])
=> #<MatchData "http://foo.com/')" 1:"http" 2:nil 3:nil 4:"foo.com" 5:nil 6:nil 7:"/')" 8:nil 9:nil>
regexp.match(%q[http://foo.com/")])
=> #<MatchData "http://foo.com/" 1:"http" 2:nil 3:nil 4:"foo.com" 5:nil 6:nil 7:"/" 8:nil 9:nil>

This was leading to the failure in the issue, because for the single quoted string, the "URL" ends on the last character (despite the ') not actually being a part of the URL!), but for the double quoted string, the parser actually ends at the "real" end of the URL, and then allowed_uri_position? fails.

This change updates the uri_range to also capture any trailing characters until the next whitespace, and then just checks that the uri_range ends at the end of the line. This fixes the issue while also continuing to register an offense for subsequent words.

Fixes #9558.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[bbatsov]

Nicely done!