[Fix #9525] Add AllowIfMethodWithArguments option to Style/SymbolProc

[koic]

Summary

Fixes #9525.

This PR adds AllowIfMethodWithArguments option to Style/SymbolProc.

AllowIfMethodWithArguments: false (default)

# bad
something.do_something(foo) { |o| o.bar }

# good
something.do_something(foo, &:bar)

AllowIfMethodWithArguments: true

# good
something.do_something(foo) { |o| o.bar }

If user prefer a style that allows block for method with arguments, the user can set true to AllowIfMethodWithArguments.

Other Information

It may be possible to consider defaulting to AllowIfMethodWithArguments: true, but at the time of this patch Style/SymbolProc cop respect keeping the existing behavior.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[bbatsov]

I'm fine with the proposed patch, but I think the name of the configuration option is quite confusing. AllowMethodsWith(Additional)Arguments seems a bit better to me (as you can argue that the block is an argument as well), but I'm wondering if we can do better. @rubocop-hq/rubocop-core who's best at naming here? 😆

It may be possible to consider defaulting to AllowIfMethodWithArguments: true, but at the time of this patch Style/SymbolProc cop respect keeping the existing behavior.

I'd keep the curernt default, as it has been around for ages and this is the first time I see someone unhappy with it.

[dvandersluis]

👍 for AllowMethodsWithArguments. It's kind of a hard concept to name. I was thinking something like MethodsWithBlockArgumentOnly but that's clumsier IMO.

[koic]

Thank you for the feedback! I renamed the option AllowMethodsWithArguments.

I was thinking something like MethodsWithBlockArgumentOnly

I think this name is also a good candidate :-)

[bbatsov]

Thanks!