Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9523] Fix an error for Style/TrailingMethodEndStatement #9524

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 17, 2021

Fixes #9523.

This PR fixes an error for Style/TrailingMethodEndStatement when endless method definition signature and body are on different lines.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_error_for_style_trailing_method_end_statement branch from a4de24c to 94c35b9 Compare February 17, 2021 12:16
Fixes rubocop#9523.

This PR fixes an error for `Style/TrailingMethodEndStatement`
when endless method definition signature and body are on different lines.
@koic koic force-pushed the fix_error_for_style_trailing_method_end_statement branch from 94c35b9 to 57488bf Compare February 17, 2021 12:21
@bbatsov bbatsov merged commit 8bd7679 into rubocop:master Feb 17, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 17, 2021

Thanks!

@koic koic deleted the fix_error_for_style_trailing_method_end_statement branch February 17, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with parsing ruby 3.0 endless method definition
2 participants